Skyglade Site Skin Bugs: Difference between revisions

From Caves of Narshe Development Wiki
Jump to navigation Jump to search
Line 18: Line 18:
* <del>I think we should add semibold and map this to &lt;b> and &lt;strong>, as bolded body text seems to look like death for some reason. This should be font-weight 600 (officially anyway - we could play around if necessary, at the risk of doing unpleasant things to the Arial fallback).</del>
* <del>I think we should add semibold and map this to &lt;b> and &lt;strong>, as bolded body text seems to look like death for some reason. This should be font-weight 600 (officially anyway - we could play around if necessary, at the risk of doing unpleasant things to the Arial fallback).</del>
* <del>.newsheading should not define a font size - this makes the h1 tiny in individual news pages. .newsheading SHOULD override the hx styles by removing the underscore and any bottom margin/padding in all cases.</del>
* <del>.newsheading should not define a font size - this makes the h1 tiny in individual news pages. .newsheading SHOULD override the hx styles by removing the underscore and any bottom margin/padding in all cases.</del>
* Quiz History page is missing styles on the table. Probably some bad markup. Not quite sure, needs more review but not immediately.


[[Category:Skyglade]]
[[Category:Skyglade]]

Revision as of 20:27, 19 April 2012

I'm having trouble processing all the bugs in the site skin using Bugzilla, so I'm going to try moving them in here so I can have better luck trying to track them. If there are things that have previously been fixed, I'm leaving them in the bug ( http://developer.cavesofnarshe.com/bugs/show_bug.cgi?id=288 ).

Themes

  • Also, as discussed earlier: Zenan has no fill/spectrum in its dropdowns, and its sidebar should probably be warmer like the table cells.
  • Popups now work, but they're not inheriting the styles correctly. I think I'm missing top minimal, will need to look into that to verify. Pending more testing, of course

XMLNav

  • Clicking the dropdowns should focus things, and this either isn't implemented yet or isn't working yet. Chat should move focus to the nickname box and select it all; poll should focus "more polls" on the results (not sure about the vote page). This is shown working as intended on the development page. Josh is considering redoing the JS in jQuery. That presents its own problems, of course. Deferring for now.
  • It is almost impossible to use Skyglade on a test server because none of the XMLnav parser bothers with $GLOBALS['BASE_URL']. In fact almost everything I've downloaded recently to make local CoN work seems to ignore this critical system variable.
  • The News nav is slightly incorrect: it is missing the leading navheader, "By Month". It is correct to omit the top "gamename" header, but never any navheaders.
  • Submitting polls or visiting the poll section crashes. Also, immediately after submitting a poll or hitting "view results", the Poll dropdown should start open on the following page. (Or I guess we could just AJAX that whole business.) Or we could redirect a submitted poll to the poll page for that poll. Will deal with this once we know what the final JS is going to look like.

General Markup

  • #sectiontitle should not be present at all on pages where there is no section title. Once the section titles are implemented properly, there should be little more than the front page without one. This is partially fixed. I need to investigate how it will work for non-game pages before I call it done, this will take more effort to get in line.

General CSS

  • The style includes "con6-core-ie.css" without any pathspec so this is probably being ignored. If possible, we should merge con6-core* styles into style-defaults, as this CSS was intended ultimately to replace that in a new backend. If this is not possible, con6-core* should be moved up a level from Skyglade so that it is available to other themes that may want to make use of it.
  • I think we should add semibold and map this to <b> and <strong>, as bolded body text seems to look like death for some reason. This should be font-weight 600 (officially anyway - we could play around if necessary, at the risk of doing unpleasant things to the Arial fallback).
  • .newsheading should not define a font size - this makes the h1 tiny in individual news pages. .newsheading SHOULD override the hx styles by removing the underscore and any bottom margin/padding in all cases.
  • Quiz History page is missing styles on the table. Probably some bad markup. Not quite sure, needs more review but not immediately.