Skyglade Site Skin Bugs
I'm having trouble processing all the bugs in the site skin using Bugzilla, so I'm going to try moving them in here so I can have better luck trying to track them. If there are things that have previously been fixed, I'm leaving them in the bug ( http://developer.cavesofnarshe.com/bugs/show_bug.cgi?id=288 ).
Themes
Also, as discussed earlier: Zenan has no fill/spectrum in its dropdowns, and its sidebar should probably be warmer like the table cells.Popups now work, but they're not inheriting the styles correctly. I think I'm missing top minimal, will need to look into that to verify.Pending more testing, of course- We should probably follow the Arch model of putting the basic headers in a file that both top and topminimal include.
On some subthemes (e.g. Cosmo) the hover and current game and section pick up the theme text colour, to match headings. On others (e.g. Ordeals) this does not seem to happen. I'm not seeing what you're talking about here, I'll grab you about it later.Game-specific fanart only gets themed if it's refered from a game-specific search page. That classification should take priority, but if the fanart contains subjects from only one game, the page should take that game's theme regardless of how you got there. (Multiple game ones should probably take Grasslands in this case.)Images for the bottom of dropdowns should be preloaded (zero-size element?)- Not necessarily a Skyglade bug, but if you have no avatar, the placeholder on the front page is always the Persona logo. Might be better to use the existing styles for the Welcome message for that case.
XMLNav
Clicking the dropdowns should focus things, and this either isn't implemented yet or isn't working yet. Chat should move focus to the nickname box and select it all; poll should focus "more polls" on the results (not sure about the vote page). This is shown working as intended on the development page. A new jQuery version is available, and needs to be tested in various browsers. Seems okay in FF11 and Chrome, needs testing in IE.It is almost impossible to use Skyglade on a test server because none of the XMLnav parser bothers with $GLOBALS['BASE_URL']. In fact almost everything I've downloaded recently to make local CoN work seems to ignore this critical system variable.The News nav is slightly incorrect: it is missing the leading navheader, "By Month". It is correct to omit the top "gamename" header, but never any navheaders.Submitting polls or visiting the poll section crashes. Also, immediately after submitting a poll or hitting "view results", the Poll dropdown should start open on the following page. (Or I guess we could just AJAX that whole business.) Or we could redirect a submitted poll to the poll page for that poll. Will deal with this once we know what the final JS is going to look like.Zend Compatibility breaks the poll. Tiddles says: 13:47:41: Probably best to ini_set it off before calling XMLnav in Skyline. 13:47:50: Then ini_set it back on explicitly in the poll pages.- FF6 has a strange nav with repeated sections under GUIDES and GAME DATA for now. This will need adapting to either the old or the new section depending on what's there on Skyglade release day.
Things that aren't links in the sidebar shouldn't be links. (active game version, possibly others). Requires a tweak to the XML files and the parser both.
General Markup
#sectiontitle should not be present at all on pages where there is no section title. Once the section titles are implemented properly, there should be little more than the front page without one.Section titles are looking very good indeed, though I think the nav and title bits for AmaCoN would be better as Store.We need to find some way to make the right gamenav bits highlight when in the relevant forums, which is made more cumbersome by the stupid way I've included the header.This page should be branded "Forums": http://www.cavesofnarshe.com/forums/rules.php We should brand the dud forum header include page the same way (/layout/Skyglade/foruminc.php IIRC?) which would mean the hokey branding regex in the forum theme could be removed.Guides and Info being the default tab type is a good idea to save us page update work, but some pages should have no active tab (e.g. the front page and most of the stuff on its sidebar). There needs to be a way to override in these files."ABOUT" probably shouldn't be a sectiontitle at all, and it definitely shouldn't appear on error pages.Chat and Poll topnav boxes are too small compared to the others - they have 3px rather than 10px side padding. This is because they're taking the topnav-short class, which ironically was intended to pad out short entries more than longer ones. I'd remove all trace of that - it's not needed with Skyglade styling.
General CSS
The style includes "con6-core-ie.css" without any pathspec so this is probably being ignored.If possible, we should merge con6-core* styles into style-defaults, as this CSS was intended ultimately to replace that in a new backend. If this is not possible, con6-core* should be moved up a level from Skyglade so that it is available to other themes that may want to make use of it.I think we should add semibold and map this to <b> and <strong>, as bolded body text seems to look like death for some reason. This should be font-weight 600 (officially anyway - we could play around if necessary, at the risk of doing unpleasant things to the Arial fallback)..newsheading should not define a font size - this makes the h1 tiny in individual news pages. .newsheading SHOULD override the hx styles by removing the underscore and any bottom margin/padding in all cases.- Quiz History page is missing styles on the table. Probably some bad markup. Not quite sure, needs more review but not immediately.
- The Quiz Hall of Fame Tiers lack proper toprow styling. http://www.cavesofnarshe.com/quiz/topscorers.php?tier=1 The full HoF with no query string) is fine.